Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type ascription to implicits from instantiable #3615

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Add type ascription to implicits from instantiable #3615

merged 1 commit into from
Nov 2, 2023

Conversation

jackkoenig
Copy link
Contributor

This is needed by users of Chisel using Scala 2.13.12

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

This fixes Scala compiler warnings in Scala 2.13.12 requiring type ascriptions on public implicit definitions.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Nov 2, 2023
@jackkoenig jackkoenig added this to the 3.6.x milestone Nov 2, 2023
@jackkoenig
Add type ascription to implicits from instantiable
0fbf9f3 
This fixes Scala compiler warnings in Scala 2.13.12 requiring type
ascriptions on public implicit definitions.
@jackkoenig jackkoenig force-pushed the instantiable-implicit-type-ascription branch from b00004e to 0fbf9f3 Compare November 2, 2023 22:50
@jackkoenig jackkoenig changed the title Add type ascription to implicits from @instantiable Add type ascription to implicits from instantiable Nov 2, 2023
@jackkoenig jackkoenig mentioned this pull request Nov 2, 2023
Merged
14 tasks
seldridge
seldridge approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Feel free to land simple changes like this directly. 😉

@jackkoenig jackkoenig enabled auto-merge (squash) November 2, 2023 22:54
@jackkoenig
Copy link
Contributor Author

Feel free to land simple changes like this directly.

I need this one to backport 🙂

@jackkoenig jackkoenig merged commit d011b44 into main Nov 2, 2023
14 checks passed
@jackkoenig jackkoenig deleted the instantiable-implicit-type-ascription branch November 2, 2023 23:15
@mergify mergify bot added the Backported This PR has been backported label Nov 2, 2023
mergify bot pushed a commit that referenced this pull request Nov 2, 2023
@jackkoenig @mergify
Add type ascription to implicits from instantiable (#3615)
7e6152d 
This fixes Scala compiler warnings in Scala 2.13.12 requiring type
ascriptions on public implicit definitions.

(cherry picked from commit d011b44)
@mergify mergify bot mentioned this pull request Nov 2, 2023
Merged
14 tasks
mergify bot pushed a commit that referenced this pull request Nov 2, 2023
@jackkoenig @mergify
Add type ascription to implicits from instantiable (#3615)
79dd54b 
This fixes Scala compiler warnings in Scala 2.13.12 requiring type
ascriptions on public implicit definitions.

(cherry picked from commit d011b44)
@mergify mergify bot mentioned this pull request Nov 2, 2023
Merged
14 tasks
mergify bot added a commit that referenced this pull request Nov 2, 2023
@mergify @jackkoenig
Add type ascription to implicits from instantiable (#3615) (#3618)
115743e 
This fixes Scala compiler warnings in Scala 2.13.12 requiring type
ascriptions on public implicit definitions.

(cherry picked from commit d011b44)

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request Nov 2, 2023
@mergify @jackkoenig
Add type ascription to implicits from instantiable (#3615) (#3617)
1247147 
This fixes Scala compiler warnings in Scala 2.13.12 requiring type
ascriptions on public implicit definitions.

(cherry picked from commit d011b44)

Co-authored-by: Jack Koenig <koenig@sifive.com>
seldridge added a commit that referenced this pull request Nov 4, 2023
@seldridge
fixup! Add type ascription to implicits from instantiable (#3615)
35c1182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@azidar azidar Awaiting requested review from azidar

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @seldridge