-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update Connectable explanation #3664
[docs] Update Connectable explanation #3664
Conversation
@tymcauley can you sign the Linux Foundation CLA? We recently switched to it so that we can finish the process of Chisel being an official ChipsAlliance project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think we should have changed Coerced
to Child
in that one part.
@jackkoenig sounds like there might be a bit of a delay in getting that sorted out on my company's end. I'll let you know when I've got an ETA, but we might not be able to actually land this for a bit. |
d505ef3
to
1097b34
Compare
1097b34
to
5df1174
Compare
Fix typos, capitalization, and some code-formatting inconsistencies.
5df1174
to
d0fd94a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tynan!
Questioned change was backed out
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.5.x
,3.6.x
, or5.x
depending on impact, API modification or big change:6.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.