-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance release notes automation #3751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump versions * It now should tab every line included in the Release Notes section of the PR template
jackkoenig
added
the
Internal
Internal change, does not affect users, will be included in release notes
label
Jan 19, 2024
jackkoenig
commented
Jan 19, 2024
Comment on lines
+59
to
70
}, | ||
{ | ||
"pattern": "\n\\s*\n", | ||
"flags": "gu", | ||
"target": "\n" | ||
}, | ||
{ | ||
"pattern": "\n", | ||
"flags": "gu", | ||
"target": "\n " | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't add comments to the JSON, but the first transformer removes blank lines (necessary to make the bulleted list look correct). The second transformer inserts two spaces after every newline (tabbing everything over).
SpriteOvO
pushed a commit
to SpriteOvO/chisel
that referenced
this pull request
Jan 20, 2024
* Bump versions * It now tabs every line included in the Release Notes section of the PR template
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
* Bump versions * It now tabs every line included in the Release Notes section of the PR template (cherry picked from commit b00b22a) # Conflicts: # .github/workflows/config/release-notes.json # .github/workflows/release-notes.yml
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
* Bump versions * It now tabs every line included in the Release Notes section of the PR template (cherry picked from commit b00b22a)
14 tasks
jackkoenig
added a commit
that referenced
this pull request
Jan 29, 2024
* Bump versions * It now tabs every line included in the Release Notes section of the PR template (cherry picked from commit b00b22a) # Conflicts: # .github/workflows/config/release-notes.json # .github/workflows/release-notes.yml Co-authored-by: Jack Koenig <koenig@sifive.com>
jackkoenig
added a commit
that referenced
this pull request
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backported
This PR has been backported
Internal
Internal change, does not affect users, will be included in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
mikepenz/release-changelog-builder-action
to v4.1.1Reviewer Checklist (only modified by reviewer)
3.5.x
,3.6.x
, or5.x
depending on impact, API modification or big change:6.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.