Support checking isVisible with reflect.DataMirror #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sequencer Are these changes OK? I tested the API in my own design and it works as expected. I'm now able to filter out already-defined, visible instances to avoid duplicated declarations. |
poemonsense
force-pushed
the
data-mirror-is-visible
branch
from
b28c1c7
to
f4ddc78
Compare
|
LGTM, please add test in DataMirrorSpec |
poemonsense
force-pushed
the
data-mirror-is-visible
branch
from
f4ddc78
to
e047b4a
Compare
sequencer
approved these changes
Jan 20, 2024
sequencer
added
the
Please Merge
Users are now able to check whether a Data is visible from the current context via `chisel.reflect.DataMirror.isVisible`.
poemonsense
force-pushed
the
data-mirror-is-visible
branch
from
e047b4a
to
cb2bdbe
Compare
poemonsense
added a commit
to OpenXiangShan/difftest
that referenced
this pull request
Jan 20, 2024
Since chipsalliance/chisel#3753, the users are able to check whether a Data is visible in the current context. To avoid a large number of duplicated LogPerfControl modules, we allow it to be reused when some previous instance is still visible to the current context. Call `LogPerfControl.reuse(DataMirror.isVisible)` instead of pure `apply()` to allow the reuse. However, this is still a temporary workaround. In the future, we need some clean methods to extract the simulation environment and access these signals during simulation, possibly via XMR.
poemonsense
added a commit
to OpenXiangShan/difftest
that referenced
this pull request
Jan 20, 2024
Since chipsalliance/chisel#3753, the users are able to check whether a Data is visible in the current context. To avoid a large number of duplicated LogPerfControl modules, we allow it to be reused when some previous instance is still visible to the current context. Call `LogPerfControl.reuse(DataMirror.isVisible)` instead of pure `apply()` to allow the reuse. However, this is still a temporary workaround. In the future, we need some clean methods to extract the simulation environment and access these signals during simulation, possibly via XMR.
poemonsense
added a commit
to OpenXiangShan/difftest
that referenced
this pull request
Jan 20, 2024
Since chipsalliance/chisel#3753, the users are able to check whether a Data is visible in the current context. To avoid a large number of duplicated LogPerfControl modules, we allow it to be reused when some previous instance is still visible to the current context. Call `LogPerfControl.reuse(DataMirror.isVisible)` instead of pure `apply()` to allow the reuse. However, this is still a temporary workaround. In the future, we need some clean methods to extract the simulation environment and access these signals during simulation, possibly via XMR.
SpriteOvO
pushed a commit
to SpriteOvO/chisel
that referenced
this pull request
Jan 20, 2024
Users are now able to check whether a Data is visible from the current context via `chisel.reflect.DataMirror.isVisible`.
pxk27
pushed a commit
to pxk27/difftest
that referenced
this pull request
Jan 30, 2024
Since chipsalliance/chisel#3753, the users are able to check whether a Data is visible in the current context. To avoid a large number of duplicated LogPerfControl modules, we allow it to be reused when some previous instance is still visible to the current context. Call `LogPerfControl.reuse(DataMirror.isVisible)` instead of pure `apply()` to allow the reuse. However, this is still a temporary workaround. In the future, we need some clean methods to extract the simulation environment and access these signals during simulation, possibly via XMR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are now able to check whether a Data is visible from the current context via
chisel.reflect.DataMirror.isVisible.Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.5.x,3.6.x, or5.xdepending on impact, API modification or big change:6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.