Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew sbt for MacOS #3762

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Homebrew sbt for MacOS #3762

merged 3 commits into from
Jan 24, 2024

Conversation

schoeberl
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Documentation or website-related

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).
  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@schoeberl schoeberl added the Documentation Only changing documentation label Jan 23, 2024
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the grammatical improvements.

Have you tested sbt with homebrew lately? I ask because I originally didn't add Homebrew intentionally due to the warning about it on the SBT docs: https://www.scala-sbt.org/download#homebrew

I'm not against adding it, I just want to make sure that problem doesn't apply, we need to make sure SBT isn't overriding the users's or they may have surprising behavior.

docs/src/installation.md Outdated Show resolved Hide resolved
@jackkoenig jackkoenig enabled auto-merge (squash) January 24, 2024 20:58
@jackkoenig jackkoenig merged commit 275036c into main Jan 24, 2024
13 checks passed
@jackkoenig jackkoenig deleted the schoeberl-patch-1 branch January 24, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Only changing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants