Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new DynamicObject.apply method to create Class instances. #3792

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Add a new DynamicObject.apply method to create Class instances. #3792

merged 2 commits into from
Jan 30, 2024

Conversation

mikeurbach
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

This is in addition to the existing support in Definition.apply. Sometimes it is not possible to use Definition.apply, for example, if you plan to bore ports through the Class being constructed. The new DynamicObject.apply method supports this, and creates a DynamicObject from the newly elaborated Class.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mikeurbach
Add a new DynamicObject.apply method to create Class instances.
aae11bd 
This is in addition to the existing support in
Definition.apply. Sometimes it is not possible to use
Definition.apply, for example, if you plan to bore ports through the
Class being constructed. The new DynamicObject.apply method supports
this, and creates a DynamicObject from the newly elaborated Class.
@mikeurbach mikeurbach added the Feature New feature, will be included in release notes label Jan 30, 2024
@mikeurbach mikeurbach added this to the 6.x milestone Jan 30, 2024
jackkoenig
jackkoenig approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but see suggestions

core/src/main/scala/chisel3/properties/Object.scala Outdated Show resolved Hide resolved
core/src/main/scala/chisel3/properties/Object.scala Show resolved Hide resolved
core/src/main/scala/chisel3/RawModule.scala Outdated Show resolved Hide resolved
@mikeurbach mikeurbach merged commit 04535d3 into main Jan 30, 2024
14 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/dynamic-object-apply branch January 30, 2024 22:14
@mergify mergify bot added the Backported This PR has been backported label Jan 30, 2024
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
@mikeurbach @mergify
Add a new DynamicObject.apply method to create Class instances. (#3792)
3f4f388 
This is in addition to the existing support in
Definition.apply. Sometimes it is not possible to use
Definition.apply, for example, if you plan to bore ports through the
Class being constructed. The new DynamicObject.apply method supports
this, and creates a DynamicObject from the newly elaborated Class.

(cherry picked from commit 04535d3)
@mergify mergify bot mentioned this pull request Jan 30, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request Jan 30, 2024
@mergify @mikeurbach @jackkoenig
Add a new DynamicObject.apply method to create Class instances. (#3792)…
1eee017 
… (#3797)

This is in addition to the existing support in
Definition.apply. Sometimes it is not possible to use
Definition.apply, for example, if you plan to bore ports through the
Class being constructed. The new DynamicObject.apply method supports
this, and creates a DynamicObject from the newly elaborated Class.

(cherry picked from commit 04535d3)

Co-authored-by: Mike Urbach <mike.urbach@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

@seldridge seldridge Awaiting requested review from seldridge

@azidar azidar Awaiting requested review from azidar

@sequencer sequencer Awaiting requested review from sequencer

Assignees
No one assigned
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Milestone
6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeurbach @jackkoenig