Report source locator in when scoping error messages

[jackkoenig]

Not really a bugfix but that seemed closest

Contributor Checklist

• Did you add Scaladoc to every public function/method?
• Did you add at least one test demonstrating the PR?
• Did you delete any extraneous printlns/debugging code?
• Did you specify the type of improvement?
• Did you add appropriate documentation in docs/src?
• Did you request a desired merge strategy?
• Did you add text to be included in the Release Notes for this change?

Type of Improvement

• Bugfix

Desired Merge Strategy

• Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

• Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
• Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
• Did you review?
• Did you check whether all relevant Contributor checkboxes have been checked?
• Did you do one of the following when ready to merge:
  • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
  • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

[seldridge]

Code looks good and this is definitely an improvement.

This hints at missing infrastructure for pretty printing multiple source locators. E.g., it would be useful if after doing one line-carat error pointing at one bad operation, you could then show the when that it escaped from. Just showing a bare source locator is better.

Something like attachNote (https://mlir.llvm.org/docs/Diagnostics/#attaching-notes) is what is ideal.

[jackkoenig]

This hints at missing infrastructure for pretty printing multiple source locators. E.g., it would be useful if after doing one line-carat error pointing at one bad operation, you could then show the when that it escaped from. Just showing a bare source locator is better.

Yeah definitely. I thought about trying to tackle that when I was making that changed but just went with the smaller touch. These errors could also be changed to be non-fatal (report error rather than throwing exception).

[jackkoenig]

It also would be super nice to have the source locator for where the current data was bound (eg. where the Wire was created). That's not currently very easy to figure out, but would definitely help improve this sort of error reporting quite a bit.