Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility for views #3818

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Fix visibility for views #3818

merged 1 commit into from
Feb 10, 2024

Conversation

jackkoenig
Copy link
Contributor

A latent issue with how Binding and lexical scope checking (aka visiblity) works in Chisel is that it is assumes a single "location" for a given Data. Aggregate Views can have multiple locations so this logic needs to be generalized. I started doing that work but it's a much larger overhaul than I was willing to commit to for a bug fix, so I ditched that idea and did something more focused. We do need to make that change eventually though.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

DataMirror.isVisible and other things checking visibility now work properly for views.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Feb 9, 2024
@jackkoenig jackkoenig added this to the 3.6.x milestone Feb 9, 2024
@jackkoenig jackkoenig merged commit 84a21f8 into main Feb 10, 2024
17 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/fix-view-visibility branch February 10, 2024 00:10
@mergify mergify bot added the Backported This PR has been backported label Feb 10, 2024
mergify bot pushed a commit that referenced this pull request Feb 10, 2024
(cherry picked from commit 84a21f8)
mergify bot pushed a commit that referenced this pull request Feb 10, 2024
(cherry picked from commit 84a21f8)

# Conflicts:
#	core/src/main/scala/chisel3/Data.scala
#	src/test/scala/chiselTests/reflect/DataMirrorSpec.scala
mergify bot pushed a commit that referenced this pull request Feb 10, 2024
(cherry picked from commit 84a21f8)

# Conflicts:
#	core/src/main/scala/chisel3/Data.scala
#	src/test/scala/chiselTests/reflect/DataMirrorSpec.scala
chiselbot pushed a commit that referenced this pull request Feb 10, 2024
(cherry picked from commit 84a21f8)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants