Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[svsim] Make EphemeralSimulator multi-processing friendly #3847

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

jackkoenig
Copy link
Contributor

I and other users have noticed rare hangs, I am not certain this fixes them but I believe it will. I also noticed on shared machines that another user owned the directory the EphemeralTester was trying to put stuff in so I could no longer run sbt test.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

  • Grab a unique temporary directory for every invocation using Java API
  • Allow multiple EphemeralSimulators to run in the same JVM (no longer necessary to single-thread)
  • Use pure Scala code to recursively delete directory at end rather than platform specific rm -rf

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Feb 22, 2024
@jackkoenig jackkoenig added this to the 5.x milestone Feb 22, 2024
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/scala/chisel3/simulator/EphemeralSimulator.scala Outdated Show resolved Hide resolved
@jackkoenig jackkoenig force-pushed the jackkoenig/enhance-ephemeral-simulator branch from 3e1645f to a862141 Compare February 22, 2024 23:04
@jackkoenig jackkoenig enabled auto-merge (squash) February 22, 2024 23:18
@jackkoenig jackkoenig merged commit 1ff43c9 into main Feb 22, 2024
12 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/enhance-ephemeral-simulator branch February 22, 2024 23:19
@mergify mergify bot added the Backported This PR has been backported label Feb 22, 2024
mergify bot pushed a commit that referenced this pull request Feb 22, 2024
(cherry picked from commit 1ff43c9)

# Conflicts:
#	src/main/scala/chisel3/simulator/EphemeralSimulator.scala
mergify bot pushed a commit that referenced this pull request Feb 22, 2024
chiselbot pushed a commit that referenced this pull request Feb 22, 2024
)

(cherry picked from commit 1ff43c9)

Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot pushed a commit that referenced this pull request Feb 22, 2024
…3847) (#3848)

* [svsim] Make EphemeralSimulator multi-processing friendly (#3847)

(cherry picked from commit 1ff43c9)

# Conflicts:
#	src/main/scala/chisel3/simulator/EphemeralSimulator.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants