-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[svsim] Make EphemeralSimulator multi-processing friendly #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jackkoenig
force-pushed
the
jackkoenig/enhance-ephemeral-simulator
branch
from
February 22, 2024 23:04
3e1645f
to
a862141
Compare
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 1ff43c9) # Conflicts: # src/main/scala/chisel3/simulator/EphemeralSimulator.scala
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 1ff43c9)
This was referenced Feb 22, 2024
chiselbot
pushed a commit
that referenced
this pull request
Feb 22, 2024
sequencer
pushed a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I and other users have noticed rare hangs, I am not certain this fixes them but I believe it will. I also noticed on shared machines that another user owned the directory the
EphemeralTester
was trying to put stuff in so I could no longer runsbt test
.Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
rm -rf
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.