Add DataProduct for Iterables and primitive types #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
Feb 23, 2024
Comment on lines
85
to
105
| implicit def seqDataProduct[A: DataProduct]: DataProduct[Seq[A]] = new DataProduct[Seq[A]] { | ||
| def seqDataProduct[A: DataProduct]: DataProduct[Seq[A]] = new DataProduct[Seq[A]] { |
There was a problem hiding this comment.
It seems like this is no longer implicit because the IterableOnce version supersedes it. Should this be deprecated and slated for removal?
There was a problem hiding this comment.
Probably, I'll add a deprecation
jackkoenig
force-pushed
the
more-dataproduct
branch
from
6d29035
to
2efbfaa
Compare
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit a0ac3fd) # Conflicts: # core/src/main/scala/chisel3/experimental/hierarchy/core/Lookupable.scala
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit a0ac3fd)
14 tasks
chiselbot
pushed a commit
that referenced
this pull request
Feb 23, 2024
sequencer
pushed a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.