Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getClassType API to Definition[T <: Class]. #3877

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Add getClassType API to Definition[T <: Class]. #3877

merged 2 commits into from
Feb 27, 2024

Conversation

mikeurbach
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

This allows users to get a ClassType for use in other Property types, which is especially useful when constructing aggregate Property types of a specific Class.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mikeurbach
Add getClassType API to Definition[T <: Class].
0bfbe02 
This allows users to get a ClassType for use in other Property types,
which is especially useful when constructing aggregate Property types
of a specific Class.
@mikeurbach mikeurbach added the Feature New feature, will be included in release notes label Feb 27, 2024
@mikeurbach mikeurbach added this to the 6.x milestone Feb 27, 2024
jackkoenig
jackkoenig approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, consider adding a hair more context to the internal error message.

core/src/main/scala/chisel3/properties/Class.scala Outdated Show resolved Hide resolved
@mikeurbach mikeurbach merged commit 8a02fb3 into main Feb 27, 2024
14 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/get-class-type branch February 27, 2024 19:55
@mergify mergify bot added the Backported This PR has been backported label Feb 27, 2024
mergify bot pushed a commit that referenced this pull request Feb 27, 2024
@mikeurbach @mergify
Add getClassType API to Definition[T <: Class]. (#3877)
d5b8d4e 
This allows users to get a ClassType for use in other Property types,
which is especially useful when constructing aggregate Property types
of a specific Class.

(cherry picked from commit 8a02fb3)
@mergify mergify bot mentioned this pull request Feb 27, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request Feb 27, 2024
@mergify @mikeurbach
Add getClassType API to Definition[T <: Class]. (#3877) (#3879)
52d7246 
This allows users to get a ClassType for use in other Property types,
which is especially useful when constructing aggregate Property types
of a specific Class.

(cherry picked from commit 8a02fb3)

Co-authored-by: Mike Urbach <mike.urbach@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Milestone
6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeurbach @jackkoenig