Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ChiselStage and Builder handling of logging (backport #3895) #3898

Merged
merged 4 commits into from
Mar 7, 2024

Commits on Mar 1, 2024

  1. Fix ChiselStage and Builder handling of logging (#3895)

    Previously, object circt.stage.ChiselStage was ignoring the Logger.
    Also, Chisel was not creating its own logger scope which could lead to
    clobbering of the Console when running invoking Chisel in the same
    process multiple times.
    
    Fix various places we had to workaround this behavior and fix tests
    checking --log-level debug.
    
    (cherry picked from commit 88d147d)
    
    # Conflicts:
    #	src/main/scala/circt/stage/ChiselStage.scala
    jackkoenig authored and mergify[bot] committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7725437 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    8f29d25 View commit details
    Browse the repository at this point in the history
  2. Make logger annotations unserializable

    Change logger annotations to mix-in the Unserializable trait so that they
    will not emitted by a stage.  These annotations are not intended to be
    seen by CIRCT and these should be stripped from the output FIRRTL text.
    
    Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
    seldridge authored and jackkoenig committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8ca012c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7b92346 View commit details
    Browse the repository at this point in the history