Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeletedPath for targets that no longer exist. #3937

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

mikeurbach
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Sometimes a generator wants to emit a Path that targets some Data, but that Data isn't always produced by the generator. The DeletedPath can be used to represent the presence of a Path, but the absence of a Data in this case.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mikeurbach mikeurbach added the Feature New feature, will be included in release notes label Mar 15, 2024
@mikeurbach mikeurbach added this to the 6.x milestone Mar 15, 2024
@mikeurbach mikeurbach enabled auto-merge (squash) March 15, 2024 19:57
@mikeurbach mikeurbach merged commit 0e91187 into main Mar 15, 2024
17 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/path-deleted branch March 15, 2024 20:06
@mergify mergify bot added the Backported This PR has been backported label Mar 15, 2024
mergify bot pushed a commit that referenced this pull request Mar 15, 2024
chiselbot pushed a commit that referenced this pull request Mar 15, 2024
…3938)

* Add DeletedPath for targets that no longer exist. (#3937)

(cherry picked from commit 0e91187)

* Waive binary compatibility issues.

---------

Co-authored-by: Mike Urbach <mike.urbach@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants