Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make firtool options for elaborateGeneratedModule in workspace parametric #3952

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

rameloni
Copy link
Contributor

@rameloni rameloni commented Mar 27, 2024

Fixes #3932

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)
  • API modification

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

This adds the support in Chiselsim to configure the workspace with additional args for firtool (#3932). The user can specify how the sv circuit is compiled for simulation (i.e. including debug information -g).

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Copy link

linux-foundation-easycla bot commented Mar 27, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rameloni / name: Raffaele Meloni (a7d5f67, b4fc251)
  • ✅ login: jackkoenig / name: Jack Koenig (199b6ec)

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Mar 27, 2024
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for missing your issue, but this LGTM! It would be nice to expose this on EphemeralSimulator as well, but it's a useful improvement as is!

@jackkoenig
Copy link
Contributor

You can run formatting on the code with sbt fmt, I've run formatting and pushed to your PR

@jackkoenig jackkoenig enabled auto-merge (squash) March 27, 2024 22:18
@jackkoenig jackkoenig merged commit 9177535 into chipsalliance:main Mar 27, 2024
13 checks passed
@rameloni
Copy link
Contributor Author

You can run formatting on the code with sbt fmt, I've run formatting and pushed to your PR

Yes sure! I think intellij idea automatically reformatted the code with another fmt style. I will make sure to check it next time.

@rameloni
Copy link
Contributor Author

Apologies for missing your issue, but this LGTM! It would be nice to expose this on EphemeralSimulator as well, but it's a useful improvement as is!

Actually, I am already working on a "parametric" simulator that also makes use of custom firtool options for my project. However, it also includes some other functionalities that are specific for my project but not all of them (some are more generic like vcd/fst emission).

@jackkoenig
Copy link
Contributor

Yes sure! I think intellij idea automatically reformatted the code with another fmt style. I will make sure to check it next time.

Coincidentally it did a pretty good job, it just missed 1 rule/file 😂. Maybe it automatically picked up our format rules but didn't format that file? 🤷‍♀️

Actually, I am already working on a "parametric" simulator that also makes use of custom firtool options for my project. However, it also includes some other functionalities that are specific for my project but not all of them (some are more generic like vcd/fst emission).

Neat! Well if there's anything that you think belongs in upstream, please feel free to open issues or PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChiselSim - simulate a circuit with debug "-g" fitool option
2 participants