Support literals in DataView (backport #3964) #3965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a bug with the rename map for non 1-1 views of literals.
Contributor Checklist
docs/src
?Type of Improvement
Arguably a Feature or Bugfix, but I lean bugfix.
Desired Merge Strategy
Release Notes
View of literals will now themselves be literals. This also fixes an internal bug related to views of literals.
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.This is an automatic backport of pull request #3964 done by [Mergify](https://mergify.com).
Original PR Body
This also fixes a bug with the rename map for non 1-1 views of literals.
Contributor Checklist
docs/src
?Type of Improvement
Arguably a Feature or Bugfix, but I lean bugfix.
Desired Merge Strategy
Release Notes
View of literals will now themselves be literals. This also fixes an internal bug related to views of literals.
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.