Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SerializableModuleGenerator work with D/I #4003

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

sequencer
Copy link
Member

  • implement the instantiable SerializableModule
  • add test

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)
  • API modification
  • API deprecation
  • Backend code generation
  • Performance improvement
  • Bugfix
  • Documentation or website-related
  • Dependency update
  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).
  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@sequencer sequencer added the Feature New feature, will be included in release notes label Apr 17, 2024
@@ -17,6 +19,7 @@ trait SerializableModuleParameter
* }}}
* 3. user should guarantee the module is reproducible on their own.
*/
@instantiable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the ABI of SerializableModule, but it should be safe enough, since it only provide the new feature.

parameter,
implicitly[universe.TypeTag[M]]
),
Definition.do_apply(construct.asInstanceOf[M with BaseModule])(UnlocatableSourceInfo)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[M with BaseModule] is dirty since BaseModule doesn't allowed to be extended from a trait.
In runtime, this is always safe.

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, see comment on tests!

@sequencer sequencer force-pushed the inst-generator branch 2 times, most recently from ec8d2c6 to 8bf66a9 Compare April 18, 2024 20:17
@sequencer sequencer added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Apr 18, 2024
@chiselbot chiselbot merged commit 03ef61f into main Apr 18, 2024
17 checks passed
@chiselbot chiselbot deleted the inst-generator branch April 18, 2024 20:57
SpriteOvO pushed a commit that referenced this pull request Apr 20, 2024
* implement the instantiable SerializableModule

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants