Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide require message for negative widths #4008

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Provide require message for negative widths #4008

merged 1 commit into from
Apr 17, 2024

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Apr 17, 2024 •
edited
Loading

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Fixes #4007

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Apr 17, 2024
@jackkoenig jackkoenig added this to the 5.x milestone Apr 17, 2024
@jackkoenig jackkoenig enabled auto-merge (squash) April 17, 2024 21:58
mmaloney-sf
mmaloney-sf approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@mmaloney-sf mmaloney-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

dtzSiFive
dtzSiFive approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This suggests perhaps an audit to look for missing messages on require (if not insisting everywhere, to add them where it does help and would be useful)?

Anyway thanks for the fix!

@jackkoenig jackkoenig merged commit 751a4cf into main Apr 17, 2024
17 checks passed
@jackkoenig jackkoenig deleted the better-negative-width-error branch April 17, 2024 22:10
@mergify mergify bot added the Backported This PR has been backported label Apr 17, 2024
mergify bot pushed a commit that referenced this pull request Apr 17, 2024
@jackkoenig @mergify
Provide require message for negative widths (#4008)
dfe9e68 
(cherry picked from commit 751a4cf)

# Conflicts:
#	core/src/main/scala/chisel3/Width.scala
@mergify mergify bot mentioned this pull request Apr 17, 2024
Merged
14 tasks
mergify bot pushed a commit that referenced this pull request Apr 17, 2024
@jackkoenig @mergify
Provide require message for negative widths (#4008)
1bf655c 
(cherry picked from commit 751a4cf)

# Conflicts:
#	src/test/scala/chiselTests/UIntOps.scala
@mergify mergify bot mentioned this pull request Apr 17, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request Apr 17, 2024
@mergify @jackkoenig
Provide require message for negative widths (backport #4008) (#4009)
b5f000f 
* Provide require message for negative widths (#4008)

(cherry picked from commit 751a4cf)

# Conflicts:
#	core/src/main/scala/chisel3/Width.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot pushed a commit that referenced this pull request Apr 17, 2024
@mergify @jackkoenig
Provide require message for negative widths (backport #4008) (#4010)
edb3616 
* Provide require message for negative widths (#4008)

(cherry picked from commit 751a4cf)

# Conflicts:
#	src/test/scala/chiselTests/UIntOps.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
SpriteOvO pushed a commit that referenced this pull request Apr 20, 2024
@jackkoenig @SpriteOvO
Provide require message for negative widths (#4008)
5dcdf8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

@mmaloney-sf mmaloney-sf mmaloney-sf approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.

Negative Width Gives Bad Error Message
3 participants
@jackkoenig @dtzSiFive @mmaloney-sf