Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntrinsicModule: deprecate in favor of intrinsic expressions. #4060

Merged

Conversation

dtzSiFive
Copy link
Member

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API deprecation

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

IntrinsicModule has been replaced by Intrinsic and IntrinsicExpr .

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@dtzSiFive dtzSiFive added the Deprecation Deprecates an API, will be included in release notes label May 7, 2024
@dtzSiFive dtzSiFive added this to the 7.0 milestone May 7, 2024
@dtzSiFive dtzSiFive requested a review from jackkoenig May 7, 2024 18:50
@jackkoenig
Copy link
Contributor

This is failing due to warnings as errors, you can add a waiver here:

"cat=deprecation&origin=chisel3\\.util\\.experimental\\.BoringUtils.*:s"

@dtzSiFive dtzSiFive force-pushed the feature/intrinsic-module-deprecated branch from f6fac11 to be8b050 Compare May 7, 2024 19:44
@dtzSiFive dtzSiFive force-pushed the feature/intrinsic-module-deprecated branch from be8b050 to af67e50 Compare May 7, 2024 20:20
@dtzSiFive dtzSiFive enabled auto-merge (squash) May 7, 2024 20:34
@dtzSiFive dtzSiFive merged commit d5ed92e into chipsalliance:main May 7, 2024
15 checks passed
@dtzSiFive dtzSiFive deleted the feature/intrinsic-module-deprecated branch May 7, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecation Deprecates an API, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants