Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoringUtils: Fix tapAndRead to return same type even when not boring. #4084

Merged
merged 1 commit into from
May 23, 2024

Conversation

dtzSiFive
Copy link
Member

This should always return the same type/alignment regardless of where the original resides, so if the expectation is a fully aligned result then create one if needed.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Always return fully aligned result from tapAndRead, even if no boring performed.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This should always return the same type/alignment regardless of where
the original resides, so if the expectation is a fully aligned result
then create one if needed.
@dtzSiFive dtzSiFive added the Bugfix Fixes a bug, will be included in release notes label May 23, 2024
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackkoenig jackkoenig added this to the 6.x milestone May 23, 2024
@dtzSiFive
Copy link
Member Author

TYVM for the review!!

@dtzSiFive dtzSiFive merged commit 0cc1658 into main May 23, 2024
18 checks passed
@dtzSiFive dtzSiFive deleted the fix/tapAndRead-return-passive branch May 23, 2024 23:58
@mergify mergify bot added the Backported This PR has been backported label May 23, 2024
mergify bot pushed a commit that referenced this pull request May 24, 2024
…#4084)

This should always return the same type/alignment regardless of where
the original resides, so if the expectation is a fully aligned result
then create one if needed.

(cherry picked from commit 0cc1658)
jackkoenig pushed a commit that referenced this pull request May 24, 2024
…#4084)

This should always return the same type/alignment regardless of where
the original resides, so if the expectation is a fully aligned result
then create one if needed.

(cherry picked from commit 0cc1658)
chiselbot pushed a commit that referenced this pull request May 24, 2024
…#4084) (#4094)

This should always return the same type/alignment regardless of where
the original resides, so if the expectation is a fully aligned result
then create one if needed.

(cherry picked from commit 0cc1658)

Co-authored-by: Will Dietz <will.dietz@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants