Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn when 0.U used as value for 0-bit BundleLit field #4097

Merged
merged 1 commit into from
May 24, 2024

Conversation

jackkoenig
Copy link
Contributor

Having to add this special-case is a shame, but worthwhile. Basically, if a user writes something like:

(new MyBundle).Lit(_.field1 -> whatever, _.field2 -> (some * complex / expression).U)

We should not warn if field2 is 0-bit and that expression evaluates to 0, it's way too onerous to expect the user to handle passing 0.W to .U in this case. I think a similar thing will come up when we start warning/removing implicit truncation. It's a special-case, but it's pragmatic.

The best fix would be for 0.U to start being zero-width, but that has a ton of knock on effects and should be considered a breaking change and handled as such.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label May 24, 2024
@jackkoenig jackkoenig added this to the 6.x milestone May 24, 2024
@jackkoenig jackkoenig merged commit 151d63b into main May 24, 2024
18 checks passed
@jackkoenig jackkoenig deleted the dont-warn-on-zero-dot-u branch May 24, 2024 20:40
@mergify mergify bot added the Backported This PR has been backported label May 24, 2024
mergify bot pushed a commit that referenced this pull request May 24, 2024
chiselbot pushed a commit that referenced this pull request May 24, 2024
…4098)

(cherry picked from commit 151d63b)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants