Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support views of ports in ChiselSim #4107

Merged
merged 1 commit into from
May 29, 2024

Conversation

jackkoenig
Copy link
Contributor

Fixes #4106

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Also fix reifySingleData to return the Data itself if it is not a view.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Also fix reifySingleData to return the Data itself if it is not a view.
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label May 29, 2024
@jackkoenig jackkoenig added this to the 5.x milestone May 29, 2024
@jackkoenig jackkoenig requested a review from mwachs5 May 29, 2024 02:01
@jackkoenig jackkoenig enabled auto-merge (squash) May 29, 2024 02:26
@jackkoenig jackkoenig merged commit ca49d57 into main May 29, 2024
18 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/chiselsim-reify-views branch May 29, 2024 18:50
@mergify mergify bot added the Backported This PR has been backported label May 29, 2024
mergify bot pushed a commit that referenced this pull request May 29, 2024
Also fix reifySingleData to return the Data itself if it is not a view.

(cherry picked from commit ca49d57)

# Conflicts:
#	src/main/scala/chisel3/simulator/package.scala
mergify bot pushed a commit that referenced this pull request May 29, 2024
Also fix reifySingleData to return the Data itself if it is not a view.

(cherry picked from commit ca49d57)
chiselbot pushed a commit that referenced this pull request May 29, 2024
Also fix reifySingleData to return the Data itself if it is not a view.

(cherry picked from commit ca49d57)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChiselSim does not properly support views (e.g. FlatIO)
2 participants