Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ... top of stack trace if it isn't actually trimmed #4142

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

jackkoenig
Copy link
Contributor

I'm not sure if this is a feature, bugfix, or documentation 😂. In any case, it's a nice little improvement IMO as the ... at the top is misleading if the exception was thrown by user code.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)
  • Bugfix
  • Documentation or website-related

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Jun 4, 2024
@jackkoenig jackkoenig added this to the 6.x milestone Jun 4, 2024
@jackkoenig jackkoenig requested a review from seldridge June 4, 2024 22:30
@jackkoenig jackkoenig force-pushed the dont-ellipsis-if-not-trimmed branch from 330ed1d to dcba389 Compare June 4, 2024 22:52
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test of this looks great. I did not audit the logic deeply.

@jackkoenig jackkoenig merged commit 8327056 into main Jun 4, 2024
15 checks passed
@jackkoenig jackkoenig deleted the dont-ellipsis-if-not-trimmed branch June 4, 2024 23:36
@mergify mergify bot added the Backported This PR has been backported label Jun 4, 2024
mergify bot pushed a commit that referenced this pull request Jun 4, 2024
chiselbot pushed a commit that referenced this pull request Jun 4, 2024
)

(cherry picked from commit 8327056)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants