Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more exhaustive tests for .asTypeOf (backport #4160) #4169

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 12, 2024

This includes changing AsTypeOfSpec to be FunSpec instead of FlatSpec so that the tests can have more structure.

I'm working on making it possible to preserve literals across .asTypeOf casts (which will help with unit testing and is much more convenient for async reset). In doing so, I found the existing tests extremely lacking so I decided to lay out the existing behavior exhaustively. Please do not review this PR based on what you think should happen1, rather, treat this as documenting the existing behavior so that at least changes that should be functionally equivalent will be and we can be intentional in changing the behavior going forward.

I marked this as documentation since, at least for development purposes, it is documenting the behavior.

Marked for backporting to 6.x since I want to backport the literal preservation as well.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Documentation or website-related

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Footnotes

  1. All truncation should become an error when we get rid of implicit truncation and the "implicit extensions" for non-arithmetic types also should be an error, but that is obviously not the purpose of this PR.


    This is an automatic backport of pull request Add more exhaustive tests for .asTypeOf #4160 done by Mergify.

This includes changing AsTypeOfSpec to be FunSpec instead of FlatSpec
so that the tests can have more structure.

(cherry picked from commit 2997fa8)
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Jun 12, 2024
@github-actions github-actions bot added the Documentation Only changing documentation label Jun 12, 2024
@chiselbot chiselbot merged commit 7ccb53e into 6.x Jun 12, 2024
17 checks passed
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4160 branch June 12, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release Documentation Only changing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants