Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support XMRs to Analog in D/I #4181

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Support XMRs to Analog in D/I #4181

merged 1 commit into from
Jun 17, 2024

Conversation

jackkoenig
Copy link
Contributor

Fixes #4180

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Jun 17, 2024
@jackkoenig jackkoenig added this to the 5.x milestone Jun 17, 2024
@jackkoenig jackkoenig requested a review from azidar June 17, 2024 20:41
@jackkoenig jackkoenig enabled auto-merge (squash) June 17, 2024 20:45
@jackkoenig jackkoenig merged commit 9ec0fa2 into main Jun 17, 2024
17 checks passed
@jackkoenig jackkoenig deleted the di-analog branch June 17, 2024 20:56
@mergify mergify bot added the Backported This PR has been backported label Jun 17, 2024
mergify bot pushed a commit that referenced this pull request Jun 17, 2024
@jackkoenig @mergify
Support XMRs to Analog in D/I (#4181)
53242fd 
(cherry picked from commit 9ec0fa2)

# Conflicts:
#	core/src/main/scala/chisel3/experimental/Analog.scala
@mergify mergify bot mentioned this pull request Jun 17, 2024
Merged
14 tasks
mergify bot pushed a commit that referenced this pull request Jun 17, 2024
@jackkoenig @mergify
Support XMRs to Analog in D/I (#4181)
376279d 
(cherry picked from commit 9ec0fa2)
@mergify mergify bot mentioned this pull request Jun 17, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request Jun 17, 2024
@mergify @jackkoenig
Support XMRs to Analog in D/I (#4181) (#4183)
4c2d349 
(cherry picked from commit 9ec0fa2)

Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot pushed a commit that referenced this pull request Jun 17, 2024
@mergify @jackkoenig
Support XMRs to Analog in D/I (backport #4181) (#4182)
49b7a04 
* Support XMRs to Analog in D/I (#4181)

(cherry picked from commit 9ec0fa2)

# Conflicts:
#	core/src/main/scala/chisel3/experimental/Analog.scala

* Resolve backport conflict

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azidar azidar azidar approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.

D/I does not work properly for non-IO of type Analog
2 participants
@jackkoenig @azidar