Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BoringUtils for identity views #4220

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jackkoenig
Copy link
Contributor

We should also support non-identity views, that involves creating more secret commands (e.g. materializing a wire). This is more of a patch fix that is made important because of #4198 which results in a lot more identity views (the return value of .asTypeOf).

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Jun 26, 2024
@jackkoenig jackkoenig added this to the 6.x milestone Jun 26, 2024
@jackkoenig jackkoenig force-pushed the jackkoenig/fix-boring-of-identity-views branch from 73824c4 to 2cb4f65 Compare June 26, 2024 19:06
@jackkoenig jackkoenig force-pushed the jackkoenig/fix-boring-of-identity-views branch from 2cb4f65 to f1bc208 Compare June 26, 2024 19:53
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

@jackkoenig jackkoenig merged commit 65936c6 into main Jun 26, 2024
15 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/fix-boring-of-identity-views branch June 26, 2024 20:12
@mergify mergify bot added the Backported This PR has been backported label Jun 26, 2024
mergify bot pushed a commit that referenced this pull request Jun 26, 2024
jackkoenig added a commit that referenced this pull request Jun 26, 2024
chiselbot pushed a commit that referenced this pull request Jun 26, 2024
(cherry picked from commit 65936c6)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants