Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .toString for dynamic indexing #4260

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix .toString for dynamic indexing #4260

merged 1 commit into from
Jul 10, 2024

Conversation

jackkoenig
Copy link
Contributor

We should turn on warnings for unused variables 🙃

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Jul 9, 2024
@jackkoenig jackkoenig added this to the 5.x milestone Jul 9, 2024
adkian-sifive
adkian-sifive approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@adkian-sifive adkian-sifive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@jackkoenig jackkoenig merged commit 95b7fcc into main Jul 10, 2024
18 checks passed
@jackkoenig jackkoenig deleted the fix-dyn-index-to-string branch July 10, 2024 17:05
@mergify mergify bot added the Backported This PR has been backported label Jul 10, 2024
mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@jackkoenig @mergify
Fix .toString for dynamic indexing (#4260)
d039f77 
(cherry picked from commit 95b7fcc)

# Conflicts:
#	core/src/main/scala/chisel3/internal/firrtl/IR.scala
@mergify mergify bot mentioned this pull request Jul 10, 2024
Merged
14 tasks
mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@jackkoenig @mergify
Fix .toString for dynamic indexing (#4260)
16a8938 
(cherry picked from commit 95b7fcc)
@mergify mergify bot mentioned this pull request Jul 10, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request Jul 10, 2024
@mergify @jackkoenig
Fix .toString for dynamic indexing (backport #4260) (#4266)
c94c9e1 
* Fix .toString for dynamic indexing (#4260)

(cherry picked from commit 95b7fcc)

# Conflicts:
#	core/src/main/scala/chisel3/internal/firrtl/IR.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot pushed a commit that referenced this pull request Jul 10, 2024
@mergify @jackkoenig
Fix .toString for dynamic indexing (#4260) (#4267)
00ab184 
(cherry picked from commit 95b7fcc)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adkian-sifive adkian-sifive adkian-sifive approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @adkian-sifive