Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize Index for literal indices with LitIndex (backport #4268) #4274

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 11, 2024

Built on top of #4259 (so this should be merged after it)

The benefit comes from not boxing static indices in ILits (and BigInts although those are memoized). Each ILit is 16-bytes, not to mention at least 2 memory loads to get the index when using it.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Performance improvement

Desired Merge Strategy

  • Squash

Release Notes

This saves 16-bytes per Vec element.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4268 done by [Mergify](https://mergify.com).

This saves 16-bytes per Vec element.

(cherry picked from commit c107e31)

# Conflicts:
#	core/src/main/scala/chisel3/experimental/hierarchy/core/Lookupable.scala
#	src/main/scala/chisel3/aop/Select.scala
#	src/main/scala/chisel3/util/SRAM.scala
@mergify mergify bot added Backport Automated backport, please consider for minor release bp-conflict labels Jul 11, 2024
Copy link
Contributor Author

mergify bot commented Jul 11, 2024

Cherry-pick of c107e31 has failed:

On branch mergify/bp/6.x/pr-4268
Your branch is up to date with 'origin/6.x'.

You are currently cherry-picking commit c107e313d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   binder/src/main/scala/PanamaCIRCTConverter.scala
	modified:   core/src/main/scala/chisel3/internal/Builder.scala
	modified:   core/src/main/scala/chisel3/internal/firrtl/Converter.scala
	modified:   core/src/main/scala/chisel3/internal/firrtl/IR.scala
	modified:   src/test/scala/chiselTests/DataPrint.scala
	modified:   src/test/scala/chiselTests/Vec.scala

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/src/main/scala/chisel3/experimental/hierarchy/core/Lookupable.scala
	both modified:   src/main/scala/chisel3/aop/Select.scala
	both modified:   src/main/scala/chisel3/util/SRAM.scala

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the Performance Improves performance, will be included in release notes label Jul 11, 2024
@chiselbot chiselbot merged commit b0f0c5a into 6.x Jul 11, 2024
15 checks passed
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4268 branch July 11, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release Performance Improves performance, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants