Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate aggregate coverage but publish a single Jar #695

Merged
merged 2 commits into from
Sep 20, 2017
Merged

Generate aggregate coverage but publish a single Jar #695

merged 2 commits into from
Sep 20, 2017

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented Sep 19, 2017

No description provided.

jackkoenig
jackkoenig approved these changes Sep 20, 2017
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! I guess we should start paying attention to coverage CI soon.

@ucbjrl
Copy link
Contributor Author

ucbjrl commented Sep 20, 2017

NOTE: This will require an update to rocket-chip's project/plugins to include sbt-coverage (chipsalliance/rocket-chip#1004).

@ucbjrl ucbjrl merged commit 7af4163 into master Sep 20, 2017
@ucbjrl ucbjrl deleted the aggregate_coverage branch October 9, 2017 23:43
@kammoh kammoh mentioned this pull request Jul 25, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

@ducky64 ducky64 Awaiting requested review from ducky64

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ucbjrl @jackkoenig