Update InvalidateAPISpec tests. #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardcwang
reviewed
Nov 3, 2017
Makefile
Outdated
| @@ -57,7 +57,7 @@ ifneq (,$(RM_DIRS)) | |||
| endif | |||
|
|
|||
| scaladoc: | |||
| $(SBT) $(SBT_FLAGS) doc | |||
| $(SBT) $(SBT_FLAGS) unidoc | |||
There was a problem hiding this comment.
What's the effect of this change? Is there a difference between "sbt doc" and "sbt unidoc"?
There was a problem hiding this comment.
sbt unidoc generates scaladoc for all subprojects. If you look at the scaladoc generated by sbt doc, you'll find it's missing the definitions from coremacros and more importantly, chiselFrontend.
There was a problem hiding this comment.
Good point; would be nice to put this into the commit message.
There was a problem hiding this comment.
I've updated the PR body to mention this.
edwardcwang
approved these changes
Nov 3, 2017
|
I suppose this really should be broken up into two commits:
|
|
Seems like a good idea. |
Use DontCare on `outs` not `ins` in InvalidateAPISpec. Add additional InvalidateAPISpec tests demonstrating selective override of Strict/NotStrict behavior.
ucbjrl
force-pushed
the
invalidateapispecdoc
branch
from
ba901bc
to
fd2fe0a
Compare
ucbjrl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use DontCare on
outsnotinsin InvalidateAPISpec.Add additional InvalidateAPISpec tests demonstrating selective override of Strict/NotStrict behavior.