Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Scala steward 1560 #1607

Merged
merged 6 commits into from
May 14, 2020
Merged

Scala steward 1560 #1607

merged 6 commits into from
May 14, 2020

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented May 13, 2020

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • code cleanup

API Impact

No API impact

Backend Code Generation Impact

No impact on backend code generation

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ucbjrl ucbjrl added Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. Backport Automated backport, please consider for minor release labels May 13, 2020
@ucbjrl ucbjrl added this to the 1.3.x milestone May 13, 2020
@ucbjrl ucbjrl requested a review from a team as a code owner May 13, 2020 16:42
@ucbjrl ucbjrl mentioned this pull request May 13, 2020
Closed
chick
chick approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look ok

@jackkoenig jackkoenig removed the Backport Automated backport, please consider for minor release label May 13, 2020
@ucbjrl ucbjrl added Backport Automated backport, please consider for minor release and removed Backport Automated backport, please consider for minor release labels May 14, 2020
@jackkoenig
Copy link
Contributor

I tried manually rerunning the fasted job, unfortunately freechipsproject is hammering Travis right now so not sure when it'll get to run

@jackkoenig
Copy link
Contributor

jk it's running right now

@mergify mergify bot merged commit d6e3cd0 into master May 14, 2020
mergify bot pushed a commit that referenced this pull request May 14, 2020
@ucbjrl
Update json4s-native to 3.6.8 (#1607)
fa2aa84 
Co-authored-by: Scala Steward <me@scala-steward.org>
Co-authored-by: Scala Steward <43047562+scala-steward@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit d6e3cd0)
@mergify mergify bot mentioned this pull request May 14, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label May 14, 2020
@jackkoenig
Copy link
Contributor

It worked 🎉

mergify bot added a commit that referenced this pull request May 14, 2020
@mergify @ucbjrl
Update json4s-native to 3.6.8 (#1607) (#1615)
8449224 
Co-authored-by: Scala Steward <me@scala-steward.org>
Co-authored-by: Scala Steward <43047562+scala-steward@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit d6e3cd0)

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
@ucbjrl ucbjrl deleted the scala-steward-1560 branch May 14, 2020 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chick chick chick approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.3.x
Development

Successfully merging this pull request may close these issues.
4 participants
@ucbjrl @jackkoenig @chick @scala-steward