Bump firrtl #2239
Merged
Bump firrtl #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features * Reset inference now supports last connect semantics Fixes * FirrtlOptions and CircuitOptions no longer serialized to anno JSON file
|
I have unit tests for the assertion that this enables using FIRRTL's reset inference on branch https://github.com/chipsalliance/rocket-chip/tree/lazyrawmoduleimp-abstract-reset, I am thinking about how to integrate them into the regressions, it's a little tricky. |
aswaterman
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables using FIRRTL's reset inference with Diplomatic LazyModule hierarchies.
Replaces #2230
Summary of changes
Features
Fixes
Related issue:
Type of change: other enhancement
Impact: API addition (no impact on existing code)
Development Phase: implementation
Release Notes
1.2.xjust beyond1.2.2