Improve DecodeLogic runtime #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For cases where none of the clauses (nor the default) is X, skip the optimization problem altogether. It turns out this is both a common and problematic case. For a design I'm working on, it reduced the runtime to about 10s from [whenver I Ctrl-C'd the thing after several minutes].
aswaterman
force-pushed
the
improve-decodelogic-runtime
branch
from
85fdc6d to
4b3132f
Compare
jackkoenig
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cases where none of the clauses (nor the default) is X, skip the
optimization problem altogether.
It turns out this is both a common and problematic case. For a design I'm
working on, it reduced the runtime to about 10s from [whenver I Ctrl-C'd the
thing after several minutes].
Type of change: other enhancement
Impact: no functional change