Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make scalatest rule depend on FIRRTL_JAR #2517

Merged
merged 1 commit into from
Jun 12, 2020
Merged

make scalatest rule depend on FIRRTL_JAR #2517

merged 1 commit into from
Jun 12, 2020

Conversation

albertchen-sifive
Copy link
Contributor

Related issue:
sbt test depends on FIRRTL_JAR which puts the firrtl-test.jar files in the test_lib dir

Type of change: bug report

Impact: no functional change

Development Phase: implementation

Release Notes

@azidar
Copy link
Contributor

azidar commented Jun 12, 2020

Awesome! Great quick fix :)

@albertchen-sifive albertchen-sifive merged commit 3001d50 into master Jun 12, 2020
@albertchen-sifive albertchen-sifive deleted the depend-on-firrtl-jar branch June 12, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azidar azidar azidar approved these changes

@seldridge seldridge Awaiting requested review from seldridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertchen-sifive @azidar