Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 TLB: Add support for configurable L1 TLB (sets/ways) #2574

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

ncppd
Copy link
Contributor

@ncppd ncppd commented Jul 24, 2020

With this PR I add support for configurable L1 Data/Instruction TLB by specifying the number of the sets and entries. The sectored TLB entry mechanism is supported along with the configurable TLB logic. I also add replacement policy support for the set-associative TLB mechanism using the existing replacement policies.

(I am not sure if I should rename nTLBEntries to nTLBWays which is more relevant with this approach.)

Type of change: other enhancement

Impact: no API modification

Development Phase: implementation

Copy link
Contributor

@ingallsj ingallsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

I am not sure if I should rename nTLBEntries to nTLBWays which is more relevant with this approach.

I'm in favor of renaming nTLBEntries to nTLBWays, as used in this PR, else calculating nTLBWays as nTLBEntries/nTLBSets.

Copy link
Contributor

@ingallsj ingallsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

I am not sure if I should rename nTLBEntries to nTLBWays which is more relevant with this approach.

I'm in favor of renaming nTLBEntries to nTLBWays, as used in this PR, else calculating nTLBWays as nTLBEntries/nTLBSets.

Also, can you please rebase this PR onto a newer version of the main branch to resolve merge conflicts?

@ncppd ncppd force-pushed the configurable-L1-TLB-v1 branch from bdda9e2 to 5483823 Compare August 27, 2020 11:58
@ingallsj ingallsj merged commit c98c330 into chipsalliance:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants