Relax master parameter of RocketCrossingParams #2634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
This change is meant to allow for using more generic or even specialized implementations of the master parameter of RocketCrossingKey.
@hcook I'm a little bit more concerned about my change to subsystem/Configs.scala. Right now just TileMasterPortParams is used. If another subclass gets used then WithIncoherentTiles might not do the right thing. I wasn't sure if this was the best approach.