axi4: remove <>s from metadata #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erpreted as a graphml xml tag
|
This happens even though it's inside a string?! |
terpstra
approved these changes
Sep 15, 2020
rmac-sifive
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any string that could potentially show up as metadata in the graphml cannot have text bracketed by
<...>without that text being interpreted as a XML tag. Such a string was getting inserted in some cases for designs with AXIIdIndexers, a situation which was introduced by by me in #2483 (though I don't think the data in question was being ingested into the graphml at that point?)Related issue:
Type of change: bug report
Impact: no functional change
Development Phase: implementation