TileLink Monitor: C-Channel ProbeAckData/ReleaseData from Trunk permission param to any Trunk/Branch/None

[ingallsj]

Related issue:

Type of change: other enhancement

Impact: API modification

Development Phase: implementation

Release Notes
change the allowed TileLink coherence permission param for ProbeAckData/ReleaseData from TtoB/TtoN/BtoN to TtoT/TtoB/TtoN

[hcook]

Technically the 1.8.1 spec allows (TtoB, TtoN, BtoN, TtoT, BtoB, NtoN) regardless of whether data is attached to the Probe or Release, so while I think the current monitor implementation is too picky, I think switching it to a different kind of pickiness for those particular messages probably shouldn't happen without a spec change.

I recommend making it TLPermissions.isReport(bundle.param) || TLPermissions.isShrink(bundle.param) in both cases, and the data-less versions.

[ingallsj]

Technically the 1.8.1 spec allows (TtoB, TtoN, BtoN, TtoT, BtoB, NtoN) regardless of whether data is attached to the Probe or Release, so while I think the current monitor implementation is too picky, I think switching it to a different kind of pickiness for those particular messages probably shouldn't happen without a spec change.

I recommend making it TLPermissions.isReport(bundle.param) || TLPermissions.isShrink(bundle.param) in both cases, and the data-less versions.

Will do. That reduces to TLPermissions.isReport(bundle.param) for all of Probe/Release(Data) messages.