BuiltInDevices: Optional instantiation of TL adapters #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcook
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
I realllly want to refactor this such that each TLBusWrapper has a Seq[BuiltInDeviceParams], each of which has an attach method that contains the logic currently smooshed together into BuiltInDevices.attach and then that method just becomes /is replaced by a loop over calling those methods. But I guess we should think more about upstreaming HasDevices before attempting that?
|
Meaning we'd get rid of special-casing of the zero/error devices and they would be instantiated by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
Makes optional the instantiation of previously mandatory adapters for these devices, and also adds a CacheCork option for the Zero device