allow renames to multiple targets for MemoryPathToken #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcook
approved these changes
Nov 13, 2020
timsnyder-siv
approved these changes
Nov 13, 2020
|
This fixed our use case! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElaborationArtefactAnnotaionwill fail to rename if it contains aMemoryPathTokenpointing at a seq mem of an aggregate type. e.g. formem: SyncReadMem[Vec[UInt]], firrtl will renamememtomem_0,mem_1,mem_2, etc.This updates
MemoryPathTokento handle this case by renaming the token to multipleMemoryPathTokens separated by spaces. so the resulting output will look like"mem_0 mem_1 mem_2 ...Type of change: bug report
Impact: API modification
Development Phase: implementation
Release Notes