refactor SimpleHellaCacheIF to chisel3. #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingularityKChen
force-pushed
the
porting-SimpleHellaCacheIF
branch
from
eaa6860 to
1d9c2f7
Compare
sequencer
reviewed
Sep 18, 2022
| @@ -131,6 +132,7 @@ class SimpleHellaCacheIF(implicit p: Parameters) extends Module | |||
| replayq.io.nack.bits := s2_req_tag | |||
| replayq.io.resp := io.cache.resp | |||
| io.requestor.resp := io.cache.resp | |||
| io <> DontCare | |||
There was a problem hiding this comment.
I still have no idea why porting to chisel3 has different connection semantic.
There was a problem hiding this comment.
There are some IOs that are not connected which is found in CI test 7 (log is shown below). In Chisel 2, the compile options is chisel3.core.ExplicitCompileOptions.NotStrict and whether it means the IO initialization is not checked before?
Exception in thread "main" firrtl.passes.PassExceptions:
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.perf.canAcceptStoreThenRMW <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.perf.tlbMiss <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_xcpt.ae.ld <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.perf.blocked <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_nack <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_gpa <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.cache.keep_clock_enabled <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.clock_enabled <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.perf.release <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.perf.storeBufferEmptyAfterStore <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_xcpt.gf.ld <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_xcpt.ma.ld <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_xcpt.ae.st <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_xcpt.gf.st <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_nack_cause_raw <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_xcpt.ma.st <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.cache.s1_data.mask <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_xcpt.pf.ld <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.perf.grant <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.perf.canAcceptStoreThenLoad <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_uncached <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_xcpt.pf.st <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.perf.storeBufferEmptyAfterLoad <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.ordered <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.perf.acquire <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_gpa_is_pte <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.perf.canAcceptLoadThenLoad <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.replay_next <= VOID
firrtl.passes.CheckInitialization$RefNotInitializedException: : [module SimpleHellaCacheIF] Reference io is not fully initialized.
: io.requestor.s2_paddr <= VOID
firrtl.passes.PassException: 29 errors detected!
baec256 to
2c288ad
Compare
+ also remove "init = " and "next = " (with param name) as new chisel-plugin in 3.6 won't compile. + DontCare the IO as there are some unconnected IOs in some occasions.
SingularityKChen
force-pushed
the
porting-SimpleHellaCacheIF
branch
from
2c288ad to
dc0fd64
Compare
sequencer
approved these changes
Sep 20, 2022
sequencer
approved these changes
Sep 20, 2022
SingularityKChen
added a commit
to SingularityKChen/rocket-chip
that referenced
this pull request
Oct 3, 2022
+ also remove "init = " and "next = " (with param name) as new chisel-plugin in 3.6 won't compile. + DontCare the IO as there are some unconnected IOs in some occasions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
Refactor SimpleHellaCacheIF.scala to chisel3 style.