Remove RocketTilesKey, RocketCrossingKey #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jerryz123
force-pushed
the
notileskey
branch
2 times, most recently
from
9330a86 to
7f6ef7c
Compare
|
let's clean things up |
sequencer
approved these changes
Oct 8, 2022
Closed
This was referenced Oct 20, 2022
sequencer
added a commit
to sequencer/hwacha
that referenced
this pull request
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
RocketTilesKeyandRocketCrossingKeyare legacyFields, the newTilesLocatedandInstantiableTileParamsAPI is more generalized for multi-tile systems.This PR removes those keys.
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes