-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC721ABatchTransferable
and ERC721ABatchBurnable
#486
Merged
Commits on Aug 20, 2024
-
Add
batchTransferFrom
andERC721ABatchTransferable
extension (#458)* added comments on transfer hooks * added sort * added clearApprovalsAndEmitTransferEvent * added tokenBatchTransfer hooks * added _batchTransferFrom and safe variants * added ERC721ABatchTransferable extension and interface * formatting * added interface and ERC721ABatchTransferableMock * added ERC721ABatchTransferable tests (wip) * added approvalCheck * fixed duplicate call * comment * fixed next initialized * refactored lastInitPackedOwnership to use prevPackedOwnership * comments * ensured correctness of nextInitialized in slots of transferred token Ids * renamed variables * reverted to leave nextInitialized unchanged * comment * replace sort -> insertion sort * bump: prettier-plugin-solidity * prettier * added prettier-ignore * fixed nextTokenId in last array element * tests wip * refactor * updated BatchTransferable mock and extension * updated tests * add approval tests * lint * lint fix * restore original .prettierrc * fix * comments and refactor * added _batchBurn * added ERC721ABatchBurnable extension, interfaces and mock * fixed _batchBurn * fixed update of last tokenId + 1 * batchBurnable tests wip * refactor * fix * add auto-clearing of consecutive ids and set `nextInitialized` to false * batchTransfer tests refactor * tests wip * tests wip * comments * added extraData logic to batch mocks * updated batch tests * refactored ERC721A to use _updateTokenId * wip * comment * Add ERC721ABatchBurnableMock (#450) * change tokenIds in ascending order in test * removal of unneeded internal functions * prettier * removed batch transfer logic * changed _updateTokenId * fixed mock * fixed extension and mock * fixed tests and cleaned unused functions in mock * removed _updateTokenId * minor gas optimizations * comment * optimize: avoid potential double read from storage * removed bulkBurn from mock * optimization: reset _packedOwnerships for initialized sequential IDs * added tests for sequential ID clearing * added test for tokenIds in strictly ascending order * comment * optimize: keep track of prevTokenOwner to bypass duplicated logic * revert: resetting _packedOwnerships in initialized sequential IDs * cleanup * optimize: avoid potential double read from storage * refactor _batchTransfer logic * optimized and stacked not too deep * optimize: removed unneeded exists() via getApproved * removed unneeded functions and batchBurn
Configuration menu - View commit details
-
Copy full SHA for ba80d01 - Browse repository at this point
Copy the full SHA ba80d01View commit details
Commits on Aug 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7b3d048 - Browse repository at this point
Copy the full SHA 7b3d048View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66350ea - Browse repository at this point
Copy the full SHA 66350eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1e624c - Browse repository at this point
Copy the full SHA d1e624cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f4ff52 - Browse repository at this point
Copy the full SHA 1f4ff52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64fcf3a - Browse repository at this point
Copy the full SHA 64fcf3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 401a6ac - Browse repository at this point
Copy the full SHA 401a6acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 230bad1 - Browse repository at this point
Copy the full SHA 230bad1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e28d30c - Browse repository at this point
Copy the full SHA e28d30cView commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2ed86e8 - Browse repository at this point
Copy the full SHA 2ed86e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0a200a - Browse repository at this point
Copy the full SHA a0a200aView commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c48aa14 - Browse repository at this point
Copy the full SHA c48aa14View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab31bd7 - Browse repository at this point
Copy the full SHA ab31bd7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.