Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC721ABatchTransferable and ERC721ABatchBurnable #486

Merged
merged 13 commits into from
Sep 9, 2024

Commits on Aug 20, 2024

  1. Add batchTransferFrom and ERC721ABatchTransferable extension (#458)

    * added comments on transfer hooks
    
    * added sort
    
    * added clearApprovalsAndEmitTransferEvent
    
    * added tokenBatchTransfer hooks
    
    * added _batchTransferFrom and safe variants
    
    * added ERC721ABatchTransferable extension and interface
    
    * formatting
    
    * added interface and ERC721ABatchTransferableMock
    
    * added ERC721ABatchTransferable tests (wip)
    
    * added approvalCheck
    
    * fixed duplicate call
    
    * comment
    
    * fixed next initialized
    
    * refactored lastInitPackedOwnership to use prevPackedOwnership
    
    * comments
    
    * ensured correctness of nextInitialized in slots of transferred token Ids
    
    * renamed variables
    
    * reverted to leave nextInitialized unchanged
    
    * comment
    
    * replace sort -> insertion sort
    
    * bump: prettier-plugin-solidity
    
    * prettier
    
    * added prettier-ignore
    
    * fixed nextTokenId in last array element
    
    * tests wip
    
    * refactor
    
    * updated BatchTransferable mock and extension
    
    * updated tests
    
    * add approval tests
    
    * lint
    
    * lint fix
    
    * restore original .prettierrc
    
    * fix
    
    * comments and refactor
    
    * added _batchBurn
    
    * added ERC721ABatchBurnable extension, interfaces and mock
    
    * fixed _batchBurn
    
    * fixed update of last tokenId + 1
    
    * batchBurnable tests wip
    
    * refactor
    
    * fix
    
    * add auto-clearing of consecutive ids and set `nextInitialized` to false
    
    * batchTransfer tests refactor
    
    * tests wip
    
    * tests wip
    
    * comments
    
    * added extraData logic to batch mocks
    
    * updated batch tests
    
    * refactored ERC721A to use _updateTokenId
    
    * wip
    
    * comment
    
    * Add ERC721ABatchBurnableMock (#450)
    
    * change tokenIds in ascending order in test
    
    * removal of unneeded internal functions
    
    * prettier
    
    * removed batch transfer logic
    
    * changed _updateTokenId
    
    * fixed mock
    
    * fixed extension and mock
    
    * fixed tests and cleaned unused functions in mock
    
    * removed _updateTokenId
    
    * minor gas optimizations
    
    * comment
    
    * optimize: avoid potential double read from storage
    
    * removed bulkBurn from mock
    
    * optimization: reset _packedOwnerships for initialized sequential IDs
    
    * added tests for sequential ID clearing
    
    * added test for tokenIds in strictly ascending order
    
    * comment
    
    * optimize: keep track of prevTokenOwner to bypass duplicated logic
    
    * revert: resetting _packedOwnerships in initialized sequential IDs
    
    * cleanup
    
    * optimize: avoid potential double read from storage
    
    * refactor _batchTransfer logic
    
    * optimized and stacked not too deep
    
    * optimize: removed unneeded exists() via getApproved
    
    * removed unneeded functions and batchBurn
    jjranalli authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ba80d01 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Tidy, optimize

    Vectorized committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7b3d048 View commit details
    Browse the repository at this point in the history
  2. Tidy

    Vectorized committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    66350ea View commit details
    Browse the repository at this point in the history
  3. Add test

    Vectorized committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d1e624c View commit details
    Browse the repository at this point in the history
  4. Tidy

    Vectorized committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    1f4ff52 View commit details
    Browse the repository at this point in the history
  5. Tidy

    Vectorized committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    64fcf3a View commit details
    Browse the repository at this point in the history
  6. Tidy, optimize

    Vectorized committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    401a6ac View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    230bad1 View commit details
    Browse the repository at this point in the history
  8. Edit comment

    Vectorized committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    e28d30c View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Tidy tests

    Vectorized committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2ed86e8 View commit details
    Browse the repository at this point in the history
  2. Tidy

    Vectorized committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a0a200a View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Edit comment

    Vectorized committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c48aa14 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab31bd7 View commit details
    Browse the repository at this point in the history