Skip to content

Commit

Permalink
fix drone build failure
Browse files Browse the repository at this point in the history
`go install ginkgo` followed by `which ginkgo` is newly added in the upstream repo.
This is making the drone build fail for arm64 arch. The ginkgo library
gets installed under $GOPATH/bin/linux_arm64 dir. This is unlike amd64 images
which typically install go libraries under $GOPATH/bin. Since the previously mentioned
dir is not in PATH, the command `which ginkgo` fails. I've added this location to PATH
to fix the build failure. See upstream PRs linked below for more info:
kubernetes#8566
kubernetes#8569
  • Loading branch information
samkulkarni20 authored and chiukapoor committed Feb 20, 2024
1 parent 2746380 commit 45927f8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions build/run-in-docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ if [[ "$DOCKER_IN_DOCKER_ENABLED" == "true" ]]; then
#go env
go install -mod=mod github.com/onsi/ginkgo/v2/ginkgo@v2.15.0
find / -type f -name ginkgo 2>/dev/null
PATH=$PATH:$GOPATH/bin/linux_arm64
which ginkgo
/bin/bash -c "${FLAGS}"
else
Expand Down

0 comments on commit 45927f8

Please sign in to comment.