Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chocolatey 0.10 breaking some installers. #45

Closed
javydekoning opened this issue Aug 21, 2016 · 13 comments
Closed

Chocolatey 0.10 breaking some installers. #45

javydekoning opened this issue Aug 21, 2016 · 13 comments

Comments

@javydekoning
Copy link
Contributor

0.10.0 includes a major security enhancement (checksum requirement). This breaks several packages right now and will hopefully be fixed by maintainers in the future. However the cChocoPackageInstaller resource requires an ability to set the --allow-empty-checksums param.

@OxHobbs
Copy link

OxHobbs commented Aug 24, 2016

I ran into this issue as well and have added an additional property that allows you to specify a property to bypass the checksum (--allowEmptyChecksums). Added pull request to address the issue.

@ferventcoder
Copy link
Member

I appreciate the way you stated this @javydekoning. Very nice.

For other folks looking for more information, take a look at chocolatey/choco#910

@javydekoning
Copy link
Contributor Author

@FatherDragon Thanks, I also added a pull request with a slightly more dynamic approach to also allow other Choco Install Params as this feature is currently lacking. See PR #50

@ferventcoder cool, thanks for including the reference. Very nice addition to Choco :)

@4c74356b41
Copy link

Could you, perhaps enlighten me? Params = "--allow-empty-checksums" doesn't work.

Thanks!

@ferventcoder
Copy link
Member

@4c74356b41 anything with Params goes into package parameters - choco install --package-parameters 'value of Params here'

@4c74356b41
Copy link

I'm talking about cchoco. when specifying Params = "--allow-empty-checksums" package fails, but when doing the same thing manually install succeeds

@lawrencegripper
Copy link
Contributor

lawrencegripper commented Sep 1, 2016

The params argument in cChoco maps to the "--package-parameters" argument on choco not as a parameter on the choco command.

What your config will do, if I haven't missunderstood, is this..

choco install git --package-parameters '--allow-empty-checksums'

Where what you want is this...

choco install git --allow-empty-checksums

#52 is working on adding this functionality at the moment

@4c74356b41
Copy link

4c74356b41 commented Sep 1, 2016

So there's no way to install package with empty checksum using cchoco at the moment?
And no way to configure choco natively?
choco feature enable -n allowEmptyChecksums? Without adding script resource to dsc configuration?

@lawrencegripper
Copy link
Contributor

Correct, @javydekoning has kindly submitted a PR to fix this and is making some changes before we merge it in and push out an update.

@4c74356b41
Copy link

4c74356b41 commented Sep 1, 2016

hm, could you perhaps add ability to configure chocolatey: (and this could be, say, comma separated list?)

    cChocoInstaller installChoco
    {
        InstallDir = "c:\choco"
        DependsOn = "[File]ChocoDir"
        Params = "feature enable -n allowEmptyChecksums, feature enable -n allowGlobalConfirmation" 
    }

@lawrencegripper
Copy link
Contributor

We're looking at enabling this on a per-package basis, for flexibility, rather than in cChocoInstaller. Happy to discuss allowing something in cChocoInstaller but best to start a seperate issue to talk through this now.

If you'd like to look at what is being worked have a read of #52 I'm going to close off this issue for now though so we don't have two conversations running in parallel.

@ferventcoder
Copy link
Member

For posterity sake, I added all of the different options you have when you run into this issue here: chocolatey/choco#112 (comment)

The first option is consumer-based. Did you know you could pass the checksums yourself (once #52 is implemented of course)?

@4c74356b41
Copy link

yeah, I figured that out, but atm cchoco doesn't support that.
seems that the only option now is to use script extension along with cchoco to install such packages.

lawrencegripper added a commit that referenced this issue Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants