(GH-561) Warn when execution timeout has elapsed

Right now there is no warning, so it's not always clear that a timeout
was reached. Be explicit in providing that warning so users are aware
and have an avenue for adjustment if the command needs longer than a
given period of time.

src/chocolatey/infrastructure/commands/CommandExecutor.cs

@@ -21,6 +21,7 @@ namespace chocolatey.infrastructure.commands
     using System.IO;
     using adapters;
     using filesystem;
+    using logging;
     using platforms;
     using Process = adapters.Process;
 
@@ -164,6 +165,12 @@ bool allowUseWindow
                     {
                         exitCode = p.ExitCode;
                     }
+                    else
+                    {
+                        "chocolatey".Log().Warn(ChocolateyLoggers.Important, () => @"Chocolatey timed out waiting for the command to finish. The timeout 
+ specified (or the default value) was '{0}' seconds. Perhaps try a 
+ higher `--execution-timeout`? See `choco -h` for details.".format_with(waitForExitInSeconds));
+                    }
                 }
             }
 

src/chocolatey/infrastructure/commands/Execute.cs

@@ -18,6 +18,7 @@ namespace chocolatey.infrastructure.commands
     using System;
     using System.Threading;
     using System.Threading.Tasks;
+    using logging;
 
     /// <summary>
     /// Execute a method or function
@@ -70,7 +71,10 @@ public T command<T>(Func<T> function, T timeoutDefaultValue)
             if (task.IsCompleted) return task.Result;
 
             cancelToken.Cancel();
-
+            this.Log().Warn(ChocolateyLoggers.Important,() => @"Chocolatey timed out waiting for the command to finish. The timeout 
+ specified (or the default value) was '{0}' seconds. Perhaps try a 
+ higher `--execution-timeout`? See `choco -h` for details.".format_with(_timespan.TotalSeconds));
+
             return timeoutDefaultValue;
 
             //T result = timeoutDefaultValue;
@@ -92,10 +96,24 @@ public bool command(Action action)
         {
             if (action == null) return false;
 
-            var task = Task.Factory.StartNew(action);
+            var completed = false;
+
+            var cancelToken = new CancellationTokenSource();
+            cancelToken.Token.ThrowIfCancellationRequested();
+            var task = Task.Factory.StartNew(action, cancelToken.Token);
             task.Wait(_timespan);
+            completed = task.IsCompleted;
+
+            if (!completed)
+            {
+                cancelToken.Cancel();
+                this.Log().Warn(ChocolateyLoggers.Important, () => @"Chocolatey timed out waiting for the command to finish. The timeout 
+ specified (or the default value) was '{0}' seconds. Perhaps try a 
+ higher `--execution-timeout`? See `choco -h` for details.".format_with(_timespan.TotalSeconds));
+
+            }
 
-            return task.IsCompleted;
+            return completed;
         }
     }
 }