Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start-ChocolateyProcessAsAdmin should not elevate when already elevated #1126

Closed
ferventcoder opened this issue Jan 4, 2017 · 0 comments
Closed

Start-ChocolateyProcessAsAdmin should not elevate when already elevated #1126

ferventcoder opened this issue Jan 4, 2017 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement Priority_HIGH
Milestone
0.10.4

Comments

@ferventcoder
Copy link
Member

Related to #1016.

Don't elevate the process if not necessary.
@ferventcoder ferventcoder added this to the 0.10.4 milestone Jan 4, 2017
@ferventcoder ferventcoder self-assigned this Jan 4, 2017
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 4, 2017
@ferventcoder
(chocolateyGH-1126) Start-ChocolateyProcess no elevate when admin
e208ca2 
When calling Start-ChocolateyProcessAsAdmin from an already elevated
process, there is no reason to attempt to elevate the process.
ferventcoder added a commit that referenced this issue Jan 4, 2017
@ferventcoder
Merge branch 'stable'
6031bb8 
* stable:
  (GH-1117) Get-ChocolateyWebFile - Url Overrides
  (maint) Do not error on missing SMA dll resources
  (GH-1126) Start-ChocolateyProcess no elevate when admin
  (GH-1013) PowerShell external - set debug/verbose false
  (maint) Fix: PackageResult Errors if DownloadUrl is Null
  (maint) formatting
  (GH-1121) API - Do not reset loggers
  (GH-1041) Fix: Skip loading synced dlls as extensions
  (GH-1013) PowerShell - Only import installer module
  (GH-1118) Feature to disable non-elevated warnings
  (maint)(log) Show Formatted Download Progress Only
  (GH-1035) Auto Uninstaller Skip if File Doesn't Exist
  (GH-1119) Auto Uninstaller - Allow remove directly
  (build) change message
  (doc) explain upgrading licensed version
@ferventcoder ferventcoder mentioned this issue Jan 4, 2017
Open
Apteryx0 pushed a commit to Apteryx0/choco that referenced this issue Jan 23, 2017
@ferventcoder
(chocolateyGH-1126) Start-ChocolateyProcess no elevate when admin
5d37976 
When calling Start-ChocolateyProcessAsAdmin from an already elevated
process, there is no reason to attempt to elevate the process.
@tek0011 tek0011 mentioned this issue Mar 30, 2017
Closed
ferventcoder added a commit that referenced this issue Mar 30, 2017
@ferventcoder
(GH-1220) Fix: PowerShell blocks fail in Start-ChocolateyProcessAsAdmin
ff4e182 
With GH-1126 at e208ca2, the change to just run a script block
didn't work in all cases for already elevated processes.

Instead of wrapping it, just set it up as a script block and invoke the
script block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement Priority_HIGH
Projects
None yet
Milestone
0.10.4
Development

No branches or pull requests
2 participants
@ferventcoder @gep13