Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSU fails to install with space in path #1177

Closed
frankhalligan opened this issue Mar 2, 2017 · 3 comments
Closed

MSU fails to install with space in path #1177

frankhalligan opened this issue Mar 2, 2017 · 3 comments

Comments

@frankhalligan
Copy link

What You Are Seeing?

MSU-based package fails to install if there is a space in the Windows username

What is Expected?

Install to succeed

How Did You Get This To Happen? (Steps to Reproduce)

Windows 7 Professional 6.1.7601
Windows Username: Frank Halligan
Chocolatey: 0.10.3

cinst powershell

Also occurs with "cinst rsat" (and presumably any other msu-based packages)

Output Log

Full debug log: https://gist.github.com/frankhalligan/096ab580c40307a1dfe71e6c1b2151d2

Specific problem:

Setting RunAs for elevation
Command ["C:\Windows\System32\wusa.exe" C:\Users\frank halligan\AppData\Local\Temp\chocolatey\PowerShell\5.1.14409.20170301\PowerShellInstall.MSU /quiet /norestart /log:"C:\Users\frank halligan\AppData\Local\Temp\chocolatey\PowerShell.Install.evtx" ] exited with '87'.
ERROR: Running ["C:\Windows\System32\wusa.exe" C:\Users\frank halligan\AppData\Local\Temp\chocolatey\PowerShell\5.1.14409.20170301\PowerShellInstall.MSU /quiet /norestart /log:"C:\Users\frank halligan\AppData\Local\Temp\chocolatey\PowerShell.Install.evtx" ] was not successful. Exit code was '87'. See log for possible error messages.

Note the lack of quotation marks around

C:\Users\frank halligan\AppData\Local\Temp\chocolatey\PowerShell\5.1.14409.20170301\PowerShellInstall.MSU
@DarwinJS
Copy link
Contributor

DarwinJS commented Mar 3, 2017

I asked Frank to file this issue.

The line of code for MSU appears to be here: https://cloudywindows.com/post/oneliners-for-procmon-debugging-of-aws-cloud-formation-automation/

But EXE might be affected here: https://cloudywindows.com/post/oneliners-for-procmon-debugging-of-aws-cloud-formation-automation

MSIs look to be handled correctly here:

@ferventcoder ferventcoder self-assigned this Mar 3, 2017
@ferventcoder ferventcoder changed the title MSU package fails to install MSU package fails to install with space in path Mar 3, 2017
@ferventcoder
Copy link
Member

@frankhalligan @DarwinJS Thanks for logging that. This is now fixed and will be available in 0.10.4.

@ferventcoder ferventcoder added this to the 0.10.4 milestone Mar 3, 2017
@ferventcoder ferventcoder changed the title MSU package fails to install with space in path MSU fails to install with space in path Mar 3, 2017
@ferventcoder
Copy link
Member

ferventcoder commented Mar 3, 2017

Just looked and there is no additional followup for licensed customers - they are already good here. This just affects FOSS.

ferventcoder added a commit that referenced this issue Mar 3, 2017
When there is a space in the path to an MSU,
Install-ChocolateyInstallPackage was not surrounding the file path with
quotes, resulting in errors when attempting to install an MSU. Add
quotes surrounding the file path so that it does not error when there
are spaces.
ferventcoder added a commit that referenced this issue Mar 9, 2017
* stable:
  (GH-1193) Allow version check with FIPS
  (GH-1155) do not warn nupkg on pack/push
  (GH-1187) File64 - Install-ChocolateyInstallPackage
  (maint) Add 64-bit process Information variable
  (GH-1155) Warn when .nupkg/.nuspec used in args
  (GH-262) BypassProxy on IHttpClient
  (GH-1134) use console adapter for width
  (GH-1182) trace network traffic
  (GH-1181) Configure a source for self-service
  (GH-1180) Create .ignore file only in choco path
  (GH-1177) Fix: MSU fails when spaces in path
  (maint) formatting
  (GH-1178) Fix: OS_NAME not reported as Windows 10
  (GH-1134) ensure GetPackageManager w/older licensed
  (GH-1165) pass proxy bypass list to debug message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants