Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Getting Local List of Package may leave config in undesirable state #1213

Closed
ferventcoder opened this issue Mar 28, 2017 · 1 comment
Closed

[API] Getting Local List of Package may leave config in undesirable state #1213

ferventcoder opened this issue Mar 28, 2017 · 1 comment
Assignees
@ferventcoder
Labels
5 - Released Bug
Milestone
0.10.4

Comments

@ferventcoder
Copy link
Member

When running NuGetService.list_run it makes changes to configuration items for a local only type of source. However it is not a good steward and doesn't set that configuration back. That can lead to undesirable results. Ensure that it puts the config back the way it received it.
@ferventcoder ferventcoder added this to the 0.10.4 milestone Mar 28, 2017
@ferventcoder ferventcoder self-assigned this Mar 28, 2017
@ferventcoder ferventcoder changed the title Ensure that config changes list_run makes are reversed Getting Local List of Package may leave config in undesirable state Mar 28, 2017
@ferventcoder
Copy link
Member Author

This was originally changed with #223.

ferventcoder added a commit that referenced this issue Mar 28, 2017
@ferventcoder
(GH-1213) Fix: list local should reset config
71738fb 
When running `NuGetService.list_run` it makes changes to configuration
items for a local only type of source. However it is not a good steward
and doesn't set that configuration back. That can lead to undesirable
results. Ensure that it puts the config back the way it received it.
ferventcoder added a commit that referenced this issue Mar 28, 2017
@ferventcoder
Merge branch 'stable'
4deb2b8 
* stable:
  (GH-1212) Fix: downgrade should not run w/out version
  (spec) ensure config is reset between calls
  (maint) fix typo in method name
  (GH-1213) Fix: list local should reset config
  (GH-1209) (c) Chocolatey Software to specs
@ferventcoder ferventcoder changed the title Getting Local List of Package may leave config in undesirable state [API] Getting Local List of Package may leave config in undesirable state Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug
Projects
None yet
Milestone
0.10.4
Development

No branches or pull requests
2 participants
@ferventcoder @gep13