-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop saying "0 packages failed." #1259
Comments
I like it. Going to open this to up for grabs. |
This I doubt we'd change at this time though. |
I would like to take this on. I am new to working on FOSS projects, but as a third year University Student I do have programming experience and some experience with c#. |
@jaensch11 sure thing. It's open for folks currently. |
Will stop the 0 packages failed notification when the are no failed packages but still allow the notification when packages have failed.
Will stop the 0 packages failed notification when the are no failed packages but still allow the notification when packages have failed.
* pr1282: (GH-1259) Remove 0 packages failed
* stable: (GH-1259) Remove 0 packages failed
Awesome work! |
When an install is successful it would be better if the report didn't say "0 packages failed" If you're spooling through the terminal history looking for failures this unnecessarily catches your eye.
"0 packages failed does not add any new information to the "choloatey installed 3/3 packages" message that precedes it.
It would be better if it only mentioned failure when the number of packages that failed > 0. And maybe even consider changing "Chocolatey installed x/y packages" to "Chocolatey installed all packages" when x==y
The text was updated successfully, but these errors were encountered: