Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop saying "0 packages failed." #1259

Closed
stibinator opened this issue Apr 21, 2017 · 5 comments
Closed

Stop saying "0 packages failed." #1259

stibinator opened this issue Apr 21, 2017 · 5 comments

Comments

@stibinator
Copy link

stibinator commented Apr 21, 2017

When an install is successful it would be better if the report didn't say "0 packages failed" If you're spooling through the terminal history looking for failures this unnecessarily catches your eye.

"0 packages failed does not add any new information to the "choloatey installed 3/3 packages" message that precedes it.

It would be better if it only mentioned failure when the number of packages that failed > 0. And maybe even consider changing "Chocolatey installed x/y packages" to "Chocolatey installed all packages" when x==y

@ferventcoder
Copy link
Member

I like it. Going to open this to up for grabs.

@ferventcoder
Copy link
Member

And maybe even consider changing "Chocolatey installed x/y packages" to "Chocolatey installed all packages" when x==y

This I doubt we'd change at this time though.

@ZachJaensch
Copy link
Contributor

I would like to take this on. I am new to working on FOSS projects, but as a third year University Student I do have programming experience and some experience with c#.

@ferventcoder
Copy link
Member

@jaensch11 sure thing. It's open for folks currently.

ZachJaensch pushed a commit to ZachJaensch/choco that referenced this issue May 3, 2017
Will stop the 0 packages failed notification when the are no failed
packages but still allow the notification when packages have failed.
ferventcoder pushed a commit that referenced this issue May 18, 2017
Will stop the 0 packages failed notification when the are no failed
packages but still allow the notification when packages have failed.
ferventcoder added a commit that referenced this issue May 18, 2017
* pr1282:
  (GH-1259) Remove 0 packages failed
ferventcoder added a commit that referenced this issue May 18, 2017
* stable:
  (GH-1259) Remove 0 packages failed
@ferventcoder ferventcoder modified the milestones: 0.10.6, 0.10.x May 18, 2017
@ferventcoder ferventcoder self-assigned this May 18, 2017
@stibinator
Copy link
Author

Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants