Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Config output is being set to Regular Output #1396

Closed
ferventcoder opened this issue Aug 29, 2017 · 0 comments
Closed

[API] Config output is being set to Regular Output #1396

ferventcoder opened this issue Aug 29, 2017 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released API Bug
Milestone
0.10.8

Comments

@ferventcoder
Copy link
Member

For items that want to have quiet output, it appears that running methods in GetChocolatey set the output to RegularOutput. This was added in #1296, but there isn't a clear reason. It is likely added to see logs and then forgotten about.
@ferventcoder ferventcoder added this to the 0.10.8 milestone Aug 29, 2017
@ferventcoder ferventcoder self-assigned this Aug 29, 2017
ferventcoder added a commit that referenced this issue Aug 29, 2017
@ferventcoder
(GH-1396) API Fix: config output is explicitly set
d0d6ae7 
When running commands with GetChocolatey, it appears the output is
getting explicitly set to RegularOutput. Change this so that it is not
set at all here and managed by the user when they run the command. If
a call wants to be silent, with this here it would not be allowed.
Allow that call to be silent.
ferventcoder added a commit that referenced this issue Aug 29, 2017
@ferventcoder
Merge branch 'stable'
fce2bae 
* stable:
  (GH-1347) API Fix: GetConfiguration() manipulates config
  (GH-1395) API - dependency log4net >= 2.0.3
  (GH-1396) API Fix: config output is explicitly set
  (GH-1347) API method comments for Configuration
  (maint) API -move GetConfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released API Bug
Projects
None yet
Milestone
0.10.8
Development

No branches or pull requests
2 participants
@ferventcoder @gep13